Math.max(client.best_diff, worker.best_diff) defeated the whole
point of the column. ckpool keeps two separate counters:
stratum_instance.best_diff — per TCP session, in memory only,
freed on disconnect, gone on
ckpool restart.
worker_instance.best_diff — per worker name, persisted to the
logdir, restored on ckpool restart,
survives client disconnects.
Falling back to worker.best_diff when the client value was lower
meant the displayed "session" diff carried over the very events
(miner disconnect, pool restart) that should reset it.
Switch every "Best (session)" computation to read only the live
stratum_instance value. Offline workers — those with a worker
record but no current client — show 0, which is correct: there is
no current session to have a best in.
satoshi
ea4c514d78